Hello all, I'd like to submit a small patch for CTest tool. It fixes one error message from ctest_coverage command: "Looks like there are more lines in the file: ...". Original code prints line, while from logic it should print file name.
Best regards, Vlad Vinogradov
From a9d2e5a1ecfecff863fd6da9be215ebcbcf99236 Mon Sep 17 00:00:00 2001 From: Vladislav Vinogradov <vlad.vinogrado...@gmail.com> Date: Mon, 22 Dec 2014 10:24:31 +0300 Subject: [PATCH] [CTest] Fix error message in ctest_coverage command: Print file name instead of line for "Looks like there are more lines in the file:" message. --- Source/CTest/cmCTestCoverageHandler.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/CTest/cmCTestCoverageHandler.cxx b/Source/CTest/cmCTestCoverageHandler.cxx index e782886..a1d770b 100644 --- a/Source/CTest/cmCTestCoverageHandler.cxx +++ b/Source/CTest/cmCTestCoverageHandler.cxx @@ -585,7 +585,7 @@ int cmCTestCoverageHandler::ProcessHandler() if ( cmSystemTools::GetLineFromStream(ifs, line) ) { cmOStringStream ostr; - ostr << "Looks like there are more lines in the file: " << line; + ostr << "Looks like there are more lines in the file: " << fullFileName; errorsWhileAccumulating.push_back(ostr.str()); } float cper = 0; -- 2.2.0
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers