>* The hunk in Modules/CMakeDetermineCompilerId.cmake is now just a > whitespace change, so please drop it.
It's removed >* Please ensure C++ sources do not have lines exceeding 79 columns. > >* Please avoid trailing whitespace on source lines. ClangFormat with llvm configuration was run to clean some of the files up. >Next we need to add tests. Since CMake won't build with this generator we >need to add tests using the generator as part of the test suite when the >needed tools are available. Look in >Tests/CMakeLists.txt for uses of >add_test_VSWinStorePhone as an example of how this is done for another target >platform. >You can either add a new test directory with dedicated code covering >capabilities of the generator, or re-use some of the existing tests to see if >they build under the new generator, or >both. I added 2 tests. They are named "GhsMulti.arm_integrity_simarm" and "GhsMulti.arm64_integrity_simarm." >Once you get tests working, please look at submitting an experimental build to >our dashboard and posting a link to it. >You can do that from the build tree of CMake with > > ctest -C Debug -D Experimental > >(or with whatever configuration you built locally). I submitted some builds. Here's a link https://open.cdash.org/viewTest.php?buildid=3671841. I'm not sure why 9 fail. Also, the tests that I added don't show up, but I can see them in the Test.xml document. Geoffrey Viola SOFTWARE ENGINEER asirobots.com -----Original Message----- From: Brad King [mailto:brad.k...@kitware.com] Sent: Tuesday, November 25, 2014 1:06 PM To: Geoffrey Viola Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] Initial Attempt at Green Hill MULTI IDE Generator Support On 11/17/2014 05:16 PM, Geoffrey Viola wrote: > I made some changes and rebased on the trunk. Thanks. Here are a few minor comments: * The hunk in Modules/CMakeDetermineCompilerId.cmake is now just a whitespace change, so please drop it. * Please ensure C++ sources do not have lines exceeding 79 columns. * Please avoid trailing whitespace on source lines. Next we need to add tests. Since CMake won't build with this generator we need to add tests using the generator as part of the test suite when the needed tools are available. Look in Tests/CMakeLists.txt for uses of add_test_VSWinStorePhone as an example of how this is done for another target platform. You can either add a new test directory with dedicated code covering capabilities of the generator, or re-use some of the existing tests to see if they build under the new generator, or both. Once you get tests working, please look at submitting an experimental build to our dashboard and posting a link to it. You can do that from the build tree of CMake with ctest -C Debug -D Experimental (or with whatever configuration you built locally). Thanks, -Brad This message contains confidential information and is intended only for the recipient. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately if you have received this e-mail by mistake and delete this e-mail from your system. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.
0001-Added-some-support-for-a-Green-Hills-MULTI.patch
Description: 0001-Added-some-support-for-a-Green-Hills-MULTI.patch
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
