On 02/24/2015 05:53 AM, Radjino Bholanath wrote: > 1. Do all developers (contributors and core developers) > have to submit a code review for every change?
Every change is reviewed before it is merged to the 'master' branch for official inclusion. The process for new contributors is documented here: http://www.cmake.org/gitweb?p=cmake.git;a=blob_plain;f=CONTRIBUTING.rst;hb=master The process for authorized developers is documented here: http://www.cmake.org/Wiki/CMake/Git/Develop Contributors send patches to this mailing list and may go through a few iterations of review with an authorized developer before being integrated. Authorized developers then take such patches (or their own changes) and merge them to a 'next' branch on which extensive nightly tests are run. When testing is clean then the maintainer performs a final review before accepting changes and merging them to 'master'. > 2. Which code review tools are used? Email. No formal review tools are used currently. > 3. Are static analyzers used? If they are used: > a. Is passing the checks of the static analyzers necessary > for a change to be accepted? This is part of the nightly testing. > b. Which static analyzers are used? Clang scan-build. We also use dynamic analysis with valgrind and Clang AddressSanitizer. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
