On 02/25/2015 04:24 PM, Gregor Jasny wrote:
> Ninja build system does not support a in-Makefile verbositiy
> switch. So we use cmake --build as a fall back to extract the
> CMAKE_VERBOSE_MAKEFILE property and pass it as an optional
> -v argument to Ninja.

Thanks for working on this.

> +  if(it.Find("CMAKE_VERBOSE_MAKEFILE"))
> +    {
> +    bool verboseBuild = it.GetValueAsBool();
> +    gen->SetVerboseBuild(verboseBuild);
> +    }
>    return gen->Build("", dir,
>                      projName, target,
>                      output,

Instead of having a generator-wide state (member variable) that
affects only one method, please extend the Build() and
GenerateBuildCommand() signatures to thread the value through.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to