On 04/05/2015 11:07 PM, Matt McCormick wrote:
>> In each place that you ExpandListArgument to get the emulator
>> command and arguments and write them out before an executable
>> name, you need to be sure to make the proper call to escape
>> each argument. In each case the code just below your hunk
>> does this for the test arguments.
>
> Good catch. Fixed.
Thanks. In try_run:
> + finalCommand += " ";
> + for (std::vector<std::string>::const_iterator ei =
> + emulatorWithArgs.begin()+1;
> + ei != emulatorWithArgs.end(); ++ei)
> + {
> + finalCommand += *ei;
> + finalCommand += " ";
> + }
This still doesn't quote the arguments to the emulator.
It needs to be quoted enough to get through the command line
parsing that try_run does later. Or, things need to be
refactored to avoid extra quoting/parsing steps.
>> The Tests/RunCMake/pseudo_emulator.cxx tool must be able to
>> compile with any of the compilers we test, not just those that
>> host the build of CMake. It will be more portable to use a
>> .c file with <stdio.h> and printf.
The pseudo_emulator still needs to be converted to C, please.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
