On 04/08/2015 01:20 AM, Geoffrey Viola wrote:
> Attached is a patch based off of the previous commit.

I get conflicts applying on commit ff7ecb92.  Please resolve.

> target_compile_options(${TARGET_NAME} PUBLIC
>     ":optionsFile=\"${ABS_PATH}/rel/path/filename\"")

The COMPILE_OPTIONS are supposed to be given flags exactly as
you'd like the tools to receive them, and CMake is supposed to
take care of the quoting.  This is different than the older
COMPILE_FLAGS value that is just a command line string.

Therefore I think you should be writing:

 target_compile_options(${TARGET_NAME} PUBLIC
     ":optionsFile=${ABS_PATH}/rel/path/filename")

which is expected to work even if there is a space in the ABS_PATH
value.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to