On 06/18/2015 01:41 PM, James Johnston wrote:
> 3.  Patch Windows-Embarcadero.cmake, as I propose here.

I think that makes sense.

> +set(CMAKE_JOB_POOL_LINK BCC32LinkPool)

Hmm.  What if the user sets this too?  Perhaps we should allow
users/projects to take control of this setting by making the
whole block conditional:

  if(NOT DEFINED CMAKE_JOB_POOL_LINK)

> +get_property(_EMB_TMP_POOLS GLOBAL PROPERTY JOB_POOLS)
> +list(APPEND _EMB_TMP_POOLS BCC32LinkPool=1)
> +set_property(GLOBAL PROPERTY JOB_POOLS ${_EMB_TMP_POOLS})

This can be just

 set_property(GLOBAL APPEND PROPERTY JOB_POOLS BCC32LinkPool=1)

Please try out all the above and send a revised patch.

Thanks,
-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to