On 02/24/2015 09:47 AM, Brad King wrote: > On 02/24/2015 08:25 AM, Mark Abraham wrote: >> Some modules shoud use CMAKE_REQUIRED_FLAGS, not CMAKE_REQUIRED_DEFINITIONS, >> I think. > > Actually both technically support any flags, but the latter > only for legacy reasons. I agree CMAKE_REQUIRED_FLAGS is > clearer for this purpose. I've applied the patch with > minor tweaks: > > Check*CompilerFlag: Refactor method used to pass flags > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5d5067ae
We need to revert this change from 3.3 because it caused a regression: In CMake 3.3.0-rc3 macro CHECK_CXX_COMPILER_FLAG is broken on OSX for some flags https://public.kitware.com/Bug/view.php?id=15641 See issue tracker entry for further updates. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
