On Wed, Jul 15, 2015 at 11:07 AM, Brad King <brad.k...@kitware.com> wrote:
> On 07/15/2015 10:57 AM, Daniel Pfeifer wrote: > > The new element `ChangeId` is added to Build.xml and Test.xml. > > Did you consider adding it as an attribute in `cmCTest::StartXML` > instead? > > That would make this (very useful) information available in all xml > files. > > I think that would make sense since all submitted .xml files are > associated with the change identified by the ChangeId. > > Zack? > I did consider that. The reason I went with the current approach is that StartXML() only defines attributes on the <Site> tag, which doesn't logically seem like the right location for this information. Change ID should be associated with the build/test/update/etc step being performed. Instead, I followed the example set by <StartDateTime>, which is independently set by each of the CTest handlers. That being said, I don't have very strong feelings about this, so if you're all okay with Change ID being a Site attribute I could move it to StartXML().
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
