On 07/21/2015 11:57 AM, Clifford Yapp wrote: > The attached patch seems to work - Brad, should I submit this to the > issue tracker? If it needs any more tweaking let me know.
No issue tracker entry needed. CONTRIBUTING.rst explains that the mailing list is preferred. I'll take a look at this when I get a chance. > Looking at the target properties test, should there also be a test for > the SOURCES property? The SOURCE_DIR property in particular is > intended to work with the current behavior (relative path lists unless > original target specifier is a full path) from SOURCES, so IMHO it > might be a good idea to put a test in for that as well... There is some coverage of the SOURCES property in other tests but having a dedicated check for it would be worthwhile too. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
