Thanks for your comments. To address your first remark, I propose to introduce a new component (‘Extra', for example) to manage these new tools. For example: find_package (Java COMPONENTS Development Extra) I think it is better than removing new variables as required because this approach will require some explicit check to ensure these tools are found before usage.
Regarding your second remark, I will update my patches. Marc On 29/07/15 15:47, "Brad King" <brad.k...@kitware.com> wrote: >On 07/29/2015 04:01 AM, CHEVRIER, Marc wrote: >> here is an updated list of patches. > >Great. > >> find_package_handle_standard_args(Java >> REQUIRED_VARS Java_JAVA_EXECUTABLE Java_JAR_EXECUTABLE >> Java_JAVAC_EXECUTABLE >> Java_JAVAH_EXECUTABLE Java_JAVADOC_EXECUTABLE >> + Java_IDLJ_EXECUTABLE Java_JARSIGNER_EXECUTABLE >> VERSION_VAR Java_VERSION >> ) > >Are idlj and jarsigner reliably available whenever the other tools are? >Even for older versions? Do these need to be REQUIRED_VARS? I'm >concerned this could make a case that previously found java not report >it found anymore. > >> - --build-project hello >> + --build-target hello > >The tests should still have --build-project as this corresponds to >the .sln file name in Visual Studio builds. The --build-target >option can be added in addition to it. > >Thanks, >-Brad > -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
