Brad King wrote: > On 07/27/2015 07:07 PM, Michael Scott wrote: >> I've changed the -W dev options to affect the deprecated warnings/errors >> as well, but only if the user hasn't used one of the options that >> control deprecated warnings (-Wdeprecated, -Wno-deprecated, >> -Werror=deprecated, -Wno-error=deprecated), if they have then the -W dev >> options won't affect the CMAKE_WARN_DEPRECATED or CMAKE_ERROR_DEPRECATED >> variables. >> >> I've also added the two -W dev options, "-Werror=dev" and >> "-Wno-error=dev", to bring this set of options in line with the >> deprecated set of options.
Thanks for working on this. Sorry it was not as straightforward as I had suggested at the start! I still think it's a bit odd that policies and message(DEPRECATED) use a different semantic though (ie, message(DEPRECATED) should issue a warning by default unless -Wno-dev is used). The branch seems to make the RunCMake.CPack_RPM test fail on my machine. I have not investigated. Thanks, Steve. Guessing configuration NoConfig Start 386: RunCMake.CPack_RPM 1/1 Test #386: RunCMake.CPack_RPM ...............***Failed 0.69 sec -- RPM/MINIMAL - PASSED CMake Error at /home/stephen/dev/src/cmake- master/Tests/RunCMake/RunCMake.cmake:129 (message): RPM/PARTIALLY_RELOCATABLE_WARNING - FAILED: Result is [1], not [0]. Command was: command> "/home/stephen/dev/src/cmake-master-build2/bin/cmake" "- DRunCMake_TEST=PARTIALLY_RELOCATABLE_WARNING" "-DGENERATOR_TYPE=RPM" "- Dsrc_dir=/home/stephen/dev/src/cmake-master/Tests/RunCMake/CPack" "- Dbin_dir=/home/stephen/dev/src/cmake-master- build2/Tests/RunCMake/RPM/CPack/PARTIALLY_RELOCATABLE_WARNING-build" "- Dconfig_file=/home/stephen/dev/src/cmake-master- build2/Tests/RunCMake/CPack/conf/RPM_config.cmake" "-P" "/home/stephen/dev/src/cmake-master/Tests/RunCMake/CPack/VerifyResult.cmake" Actual stdout: actual-out> Actual stderr: actual-err> CMake Error at /home/stephen/dev/src/cmake- master/Tests/RunCMake/CPack/VerifyResult.cmake:36 (message): actual-err> Found more than one file for file No. '1'! Found files count '0'. Files: actual-err> '' actual-err> actual-err> CPack output: 'CPack: Create package using RPM actual-err> actual-err> CPack: Install projects actual-err> actual-err> CPack: - Run preinstall target for: PARTIALLY_RELOCATABLE_WARNING actual-err> actual-err> CPack: - Install project: PARTIALLY_RELOCATABLE_WARNING actual-err> actual-err> CPack: Create package actual-err> actual-err> ' actual-err> actual-err> CPack error: 'CMake Error (dev) at actual-err> /home/stephen/dev/src/cmake- master/Modules/CPackRPM.cmake:560 (message): actual-err> actual-err> CPackRPM:Warning: Path /not_relocatable/CMakeLists.txt is not on one of the actual-err> relocatable paths! Package will be partially relocatable. actual-err> actual-err> Call Stack (most recent call first): actual-err> actual-err> /home/stephen/dev/src/cmake- master/Modules/CPackRPM.cmake:1209 (cpack_rpm_prepare_relocation_paths) actual-err> /home/stephen/dev/src/cmake- master/Modules/CPackRPM.cmake:1697 (cpack_rpm_generate_package) actual-err> actual-err> actual-err> This error is for project developers. Use -Wno-error=dev to suppress it. actual-err> actual-err> actual-err> actual-err> CPack Error: Error while execution CPackRPM.cmake actual-err> actual-err> CPack Error: Problem compressing the directory actual-err> actual-err> CPack Error: Error when generating package: PARTIALLY_RELOCATABLE_WARNING actual-err> actual-err> '; actual-err> actual-err> config file: 'set(RPM_EXECUTABLE "/usr/bin/rpm") actual-err> actual-err> set(RPMBUILD_EXECUTABLE "/usr/bin/rpmbuild")' Call Stack (most recent call first): /home/stephen/dev/src/cmake-master/Tests/RunCMake/RunCMake.cmake:143 (run_cmake) /home/stephen/dev/src/cmake- master/Tests/RunCMake/CPack/CPackTestHelpers.cmake:65 (run_cmake_command) /home/stephen/dev/src/cmake- master/Tests/RunCMake/CPack/RunCMakeTest.cmake:8 (run_cpack_test) 0% tests passed, 1 tests failed out of 1 Total Test time (real) = 0.79 sec The following tests FAILED: 386 - RunCMake.CPack_RPM (Failed) Errors while running CTest -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers