On 08/02/2015 03:31 PM, Konstantin Podsvirov wrote: > https://github.com/google/protobuf/pull/673 [snip] > I try to make find_package(Protobuf [MODULE|CONFIG]) compatible.
Thanks for working on this. Thanks for the FindProtobuf module compatibility layer. I tried your changes locally as of commit 5500b069 on Linux and Windows. The basic build and install works and I'm able to "find_package(Protobuf CONFIG)" from a test project. The structure of the produced files looks correct at a glance. The protobuf-config-version.cmake should be taught to actually check the version number to see if it is compatible with that requested. Doing so requires understanding of protbuf's version scheme and compatibility requirements. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
