On 07/08/15 13:22, Konstantin Podsvirov wrote:
> Hi developers and experts OpenSSL!
> 
> I added a little boring and dense of code at the end FindOpenSSL.cmake module.
> I just want to have imported the OpenSSL library for creating relocatable 
> packages.
> 
> I created a theme topic-imported-openssl on my server:
> http://git.podsvirov.pro/?p=kitware/cmake.git;a=shortlog;h=refs/heads/topic-imported-openssl
> 
> Now I have a single commit:
> http://git.podsvirov.pro/?p=kitware/cmake.git;a=commit;h=b47293f212f270844dcd32e36cff2a8668080c46

Two comments:
> +          INTERFACE_LINK_LIBRARIES OpenSSL::Crypto
> +          IMPORTED_LINK_INTERFACE_LIBRARIES OpenSSL::Crypto
> +          IMPORTED_LINK_INTERFACE_LIBRARIES_DEBUG OpenSSL::Crypto
> +          IMPORTED_LINK_INTERFACE_LIBRARIES_RELEASE OpenSSL::Crypto)

IMHO the last three are superfluous. Also documentation states that
IMPORTED_LINK_INTERFACE_LIBRARIES is deprecated.

> +# This module defines :prop_tgt:`IMPORTED` target ``OpenSSL::SSL`` and
> +# ``OpenSSL::Crypto``, if OPENSSL_SSL_LIBRARY and OPENSSL_CRYPTO_LIBRARY
> +# has been found.
     ^^^
have been

Thanks,
Gregor
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to