Michael Scott wrote: > Hi, > > Carrying on in the list of open issues to look at for contributing to > CMake, I've had a look at issue "15280 - FindZLIB module should find > debug and release variants". I've made some changes to the FindZLIB > module which should make it so that debug and release variants are found > as separate libraries, if they're both found then they're provided in > ZLIB_LIBRARIES and ZLIB::ZLIB's imported location properties. Attached > is the patch for FindZLIB.cmake. > > With this, I noticed that the Windows DLL's use different file names for > the release and debug variants, but I couldn't tell if this is true on > UNIX, it didn't seem to be the case. As the change to FinZLIB is based > on the two variants having different names, I'm not sure these changes > will have any effect on UNIX, is this expected or am I missing > something/going about it the wrong way?
On Unix systems those variants usually do not exists, as there are no different standard libraries (and therefore e.g. allocators) used for release and debug mode. You should use SelectLibraryConfigurations.cmake instead of building the list of libraries yourself. Look at FindPNG.cmake, which uses it. I wonder if we should add a function or macro to SLC which does the target fiddling which is done at the bottom of the patch. Eike --
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
