Good catch! The version I patched against didn't have the 
HDF5_Fortran_HL_LIBRARY_NAMES_INIT variable at the time. There was only the 
HDF5_Fortran_LIBRARY_NAMES_INIT variable. 

I'm not sure which version of the code my original patch was against after this 
long. However, since I submitted my ticket in July of 2011, Will committed 
support for the HL libraries in August of 2011 with commit 
http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ad218e4 , which added 
the HDF5_Fortran_HL_LIBRARY_NAMES_INIT variable. Perhaps that commit was 
intended to reference/fix my ticket?

At any rate, since what I submitted wouldn't apply against the current version, 
it looks like this work supersedes that patch. 

Tim

----- Original Message -----
From: "Brad King" <[email protected]>
To: "tim gallagher" <[email protected]>
Cc: [email protected], "Paul Romano" <[email protected]>
Sent: Wednesday, September 2, 2015 11:16:34 AM
Subject: Re: [cmake-developers] [PATCH] Fix a few issues in FindHDF5 module

On 09/02/2015 11:07 AM, Tim Gallagher wrote:
> It looks like the 2nd commit you linked to does the same thing as
> my patch (add hdf5hl_fortran to the Fortran library list). 

Not quite.  It is:

> -    set( HDF5_Fortran_HL_LIBRARY_NAMES_INIT hdf5hl_fortran
> +    set( HDF5_Fortran_HL_LIBRARY_NAMES_INIT hdf5hl_fortran hdf5_hl

One can see hdf5hl_fortran was already in that list.

Your patch was:

> -    set( HDF5_Fortran_LIBRARY_NAMES_INIT hdf5_fortran 
> ${HDF5_C_LIBRARY_NAMES_INIT} )
> +    set( HDF5_Fortran_LIBRARY_NAMES_INIT hdf5_fortran hdf5hl_fortran 
> ${HDF5_C_LIBRARY_NAMES_INIT} )

which adds it to a different list, though perhaps the wrong one
since it is not for the _HL component.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to