On 10/06/2015 07:51 AM, Daniele E. Domenichelli wrote: > According to the sigc++ changelog, starting with version 2.5.1, sigc++ > requires c++11 enabled, hence this patch.
Thanks. > +* Starting with sigc++ 2.5.1, c++11 must be enabled in order to use > + sigc++. Generally we don't do release notes for bug fixes, but this is somewhat of a new feature since it enables C++11 automatically for the client project. Please word the release note as a feature that the imported target provides. > + set_property(TARGET GTK2::sigc++ PROPERTY > INTERFACE_COMPILE_FEATURES cxx_alias_templates cxx_lambdas) Nice. Please add a comment to explain that these are the features needed by clients in order to include the project headers. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
