Thanks for the feedback.

Please split up the rest of the patch into a
series of steps like that
Okay I'll see if I can break it down further.

ignoreWarningLevels => force
Yes that does sound better, thanks.

increments the count by default instead of only when an explicit
option has been set.  Please revise accordingly based on the attached
state.
I don't quite follow. Setting "dev" to DIAG_WARN in DiagLevels, before the users input is parsed (which will override the default "dev" value, if any is specified), seems the clearest and most straightforward way to enable author *and **deprecate**d *warnings by default. What would the alternative be, apart from having another instance where the applicable CMake variables are set?

Cheers,
Michael
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to