Hi Roger, Thanks for working on this. Please read through this mailing list thread:
IMPORTED targets for some Find modules https://cmake.org/pipermail/cmake-developers/2014-June/010694.html There is some discussion there about similar FindBoost changes. Also please take a look at these tests: $ ls -d Tests/Find* such as FindGSL, FindOpenSSL, and FindThreads to see our current convention for adding tests for modules. See the conditions in Tests/CMakeLists.txt for adding most of them. Please add similar tests for FindBoost, at least for the new imported targets. On 11/16/2015 09:26 AM, Florent Castelli wrote: > But one there’s one thing that comes to mind. Some compiled libraries > have dependencies on other compiled libraries. > Don’t you think it would make sense to teach FindBoost about those > so we link everything properly? > > And also maybe add the native dependencies for some modules that > have one like maybe pthread or openssl. > Though, this might be hard to get right in a cross platform way. Please look at adding these. The imported targets should come with all usage requirements as if they were provided by upstream Boost. It may be tricky to get right on all platforms but if we do not do it then application code will have to do it instead. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
