Message was rejected – retrying. On Mon, Nov 16, 2015 at 9:31 AM, Levi Morrison <morrison.l...@gmail.com> wrote:
> First off, this is my first attempt at a CMake contribution ever, so > please be gentle! > > I have a few questions about my patch, though: > > Why is MSVC doing a version check around the CXX_STANDARD_DEFAULT? Should > I be doing this for Intel as well? > > I also don't know the complete version numbers for some of these things, > such as how far back they support `-std=c++98`. I only have Intel compilers > from version 12.0 and up. Should I guard the > CMAKE_CXX98_STANDARD_COMPILE_OPTION around 12 since that's all I have > available to test? > > Anyway, I appreciate any feedback. Please let me know what I should change. >
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
