On 02-Dec-15 19:44, Bartosz Kosiorek wrote:
Hi.

Currently we already support similar target properties:
- INSTALL_NAME_DIR
- INSTALL_RPATH
- INSTALL_RPATH_USE_LINK_PATH

It will be great to follow the same name convention.

Because this new property is only applicable for INSTALL step, I would like to 
propose to rename property name to INSTALL_IOS_UNIVERSAL_LIBS.

What do you think about that idea?
It's hard for me to decide what is better because IOS_INSTALL_UNIVERSAL_LIBS just came from my mind and I've used it for a while already. So now it looks solid for no reason :)

However first note:
INSTALL_RPATH can be read as when we do INSTALL change RPATH to ... (any platform)
  ANDROID_API -//- when we are on ANDROID use next API ...
  WIN32_EXECUTABLE -//- when we are on WIN32 use bla-bla for EXECUTABLE
  OSX_ARCHITECTURES -//- when we are on OSX use ARCHITECTURES
  MACOSX_BUNDLE -//- when we are on MACOSX create BUNDLE

So new property can be read as:
  IOS_INSTALL_UNIVERSAL_LIBS when we are on IOS do INSTALL_UNIVERSAL_LIBS
INSTALL_IOS_UNIVERSAL_LIBS when we do INSTALL make IOS_UNIVERSAL_LIBS (does it mean that when we are on Linux we can install iOS libs? does it mean that when we are on OSX without iOS toolchain we can do iOS libs?)

Second note is about future improvements of this feature, installing universal libs on OSX or installing universal frameworks, pattern <platform>_INSTALL_UNIVERSAL_<type>:

   IOS_INSTALL_UNIVERSAL_LIBS
   IOS_INSTALL_UNIVERSAL_FRAMEWORKS

  OSX_INSTALL_UNIVERSAL_LIBS
  OSX_INSTALL_UNIVERSAL_FRAMEWORKS

  INSTALL_UNIVERSAL_LIBS # on both OSX and iOS
  INSTALL_UNIVERSAL_FRAMEWORKS # on both OSX and iOS

  IOS_INSTALL_UNIVERSAL # both libs and frameworks
  OSX_INSTALL_UNIVERSAL # both libs and frameworks

  INSTALL_UNIVERSAL # both libs and frameworks, both OSX and iOS

?

Ruslo

________________________________________
From: cmake-developers <cmake-developers-boun...@cmake.org> on behalf of Gregor Jasny 
via cmake-developers <cmake-developers@cmake.org>
Sent: Tuesday, December 1, 2015 3:22 PM
To: CMake Developers; Ruslan Baratov
Subject: [cmake-developers] Please comment on ios-universal topic

Hello,

During the last days I worked on the iOS Universal Install topic which
now would benefit from a review. Especially the core changes could need
a third pair of eyes:

https://cmake.org/gitweb?p=stage/cmake.git;a=commit;h=8fb23b42cfc2fb7490e8645fff328add9c231713

I will now concentrate on adding more tests during the next days.

Thank you,
Gregor

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to