On 01/08/2016 05:56 PM, Mike Fitzgerald wrote: > I've got the attached, which gives me the results I'd expect
Great, thanks. I've applied this and merged to 'next' for testing: VS: Implement VS_GLOBAL_* target properties in VS 2010+ (#13666) https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=af39f115 > If I should be adding a test for this property The property has an existing smoke test in Tests/VSResource but that does not actually check that anything works. The above-linked change is acceptable on its own since the existing property was not tested for VS 2008 and below even though it was implemented. However, we'd appreciate it if you could look at adding tests. Take a look at Tests/RunCMake/XcodeProject Tests/RunCMake/SolutionGlobalSections These directories have test cases that check the actual content of the generated Xcode projects and VS .sln files. Something similar could be added to check for the results of this property in .vcxproj files. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
