On Mon, Mar 7, 2016 at 6:06 PM, Brad King <brad.k...@kitware.com> wrote: > On 03/01/2016 04:58 PM, Bruce Stephens wrote: >> I just copied the relevant code from the Makefiles generator. > > Thanks. Instead of copying, please look at moving the relevant > methods up to cmCommonTargetGenerator so it can be shared between > the two generators instead.
Ah, thanks for the class name. I did look for a suitable one but for some reason didn't spot that one (though the comment makes it obvious that it's suitable). Moving the method into there worked cleanly.
0001-Add-OS-X-dylib-versioning-to-Ninja-generator.patch
Description: Binary data
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
