On 03/16/2016 12:13 PM, Charles Huet wrote: >> On 03/16/2016 04:59 AM, Charles Huet wrote: >>> If you have other ideas on how to improve this patch, I'll be happy to >>> implement them.
All paths that are given to WritePhonyBuild in the outputs and depends options should be sent through ConvertToNinjaPath. This makes paths relative and formats slashes for Windows. This should avoid the need to do string manipulation on the paths (e.g. substr) too. Just be sure to append the "/all" before calling the conversion method. Also please keep source lines to 79 characters or less. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
