On 25/03/16 19:28, Brad King wrote: > On 03/25/2016 01:46 PM, Gregor Jasny via cmake-developers wrote: >> Does anyone see a reason to *not* prepend all <FLAGS> with a <INCLUDES>? > > I'm not particularly familiar with the ASM tooling landscape but > that prepend step is exactly what was done for all other languages > in commit v3.4.0-rc1~342^2 (Factor an <INCLUDES> placeholder out > of <FLAGS> in rule variables, 2015-07-13): > > Factor an <INCLUDES> placeholder out of <FLAGS> in rule variables > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c736de7b > > Since prior to that change the -I flags were included in <FLAGS> > I think leaving ASM changes out of the commit was an oversight.
I pushed a first commit to asm-includes topic but did not merge to next, yet. Looking at your quoted patch I wonder if <DEFINES> is missing as well? Thanks, Gregor -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
