On Wed, Apr 27, 2016 at 3:10 PM, Brad King <brad.k...@kitware.com> wrote: > On 04/26/2016 05:32 PM, Daniel Pfeifer wrote: >> This is a follow up patch: > > Thanks. > >> - tidy_cmd.insert(tidy_cmd.end(), orig_cmd.begin()+1, orig_cmd.end()); >> + tidy_cmd.insert(tidy_cmd.end(), orig_cmd.begin(), orig_cmd.end()); > > What is the purpose of this hunk? Does clang-tidy expect to be > given the full compiler command line including "cc"? This does > not look related to the change described in the commit message.
It is unrelated. Clang-Tidy picks the interesting pieces from the compiler command line and ignores the rest. Whether cc is given or not makes no difference. But maybe we should leave the decision what to pick to Clang-Tidy? It may be clearer to forward the original command line unmodified. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
