On Thu, May 12, 2016 at 10:07 PM, Brad King <brad.k...@kitware.com> wrote:
> On 05/12/2016 02:16 PM, Nicolas Desprès wrote: > > All done. Thank you for taking a look. > > https://github.com/nicolasdespres/CMake/commits/ninja-output-path-prefix > > The RunCMake.NinjaOutputPathPrefix test fails for me when I have > the CMake source and build trees in a directory with a space in > the path. Also, please move these test cases over to the > Tests/RunCMake/Ninja directory. You should be able to just append > the RunCMakeTest.cmake content. > > I have fixed the bug when a space is in the path and I added a test case when a space is in the contents of the CMAKE_NINJA_OUTPUT_PATH_PREFIX variable. I have 2 failing tests left that are not failing on master: Plugin and ExportImport. Both suffers from the same problem which comes from this part of my patch: https://github.com/nicolasdespres/CMake/commit/1f880c04bcb8cf36cf40be7fa4ef65f9525ea63e#diff-80cd058f986b2b3d5cdafc48a091411eL134 cmLocalNinjaGenerator::ConvertToLinkReference gets called by cmLocalGenerator::OutputLinkLibraries from here: https://github.com/nicolasdespres/CMake/blob/1f880c04bcb8cf36cf40be7fa4ef65f9525ea63e/Source/cmLocalGenerator.cxx#L1672 with a value that looks like this: "-Wl,-bundle_loader,/Users/polrop/Documents/cmake/_build ninja/Tests/ExportImport/Export/testExe2" The previous implementation of ConvertToLinkReference returned the string unchanged because it think it is a relative path, hiding the bug that lie on the caller site because the "if (li->IsPath)" in OutputLinkLibraries() should not be true for such a value. I don't know how to fix this. Cheers, -- Nicolas Desprès
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
