On 05/25/2016 01:25 PM, Harry Mallon wrote: > I have quite a specific problem with find_path where > "find_path(IOKIT_INCLUDE_DIR "IOKit/pci/IOPCIDevice.h")" > returns "/System/Library/Frameworks/Kernel.framework/Headers/IOKit/pci" > rather than > "/System/Library/Frameworks/Kernel.framework/Headers/".
Thanks. Please extend the Tests/RunCMake/find_path test to cover this behavior. You could add a bogus framework layout inside the test source tree. See Tests/RunCMake/README.rst for details of the test infrastructure. > + while (*fullPart++ == *relPart++) I think the logic can be simpler. The intended logic here is to get back up to the ".framework/Headers" directory. Since the glob we use always appends exactly the original file name after this, we can just clip off the matching number of characters from the result. Or, just search for the last occurrence of ".framework/Headers/" and clip off there. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
