On 06/10/2016 02:13 PM, Stephen Kelly wrote: > Things which do change in such a way should be accessed through > cmState::Snapshot, or classes which depend on cmState::Snapshot such as > cmState::Directory for directory properties, or some day cmState::Target for > target properties. That way those properties can be versioned.
Thanks for explaining, Steve. > It is true that some existing things in cmState should not be there > (commands, cache properties etc). You can consider whether now is the time > to move the cache property access to cmState::Snapshot (even without > versioning internally) instead of adding more methods related to cache > properties to cmState directly. Tobias's change is just an update to the cache properties that are already exposed directly, so I think it is fine to merge it now. The added method can be subsumed into the refactoring to move it into Snapshot. Steve, would you please add comments to cmState.h to explain the above and also mark the method groups that currently violate the design with FIXME comments? Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
