On 06/20/2016 07:55 AM, Farbos a wrote:
> I added the Glew debug library to the FindGLEW.cmake, here is the patch.

Good start.  Here are some comments:

* For compatibility with scripts that set GLEW_LIBRARY we need to
  honor the old name if it is set.  See FindZLIB for an example.
  (Near the "Allow ZLIB_LIBRARY to be set manually" comment.)

* The imported target needs to have each configuration added only
  if it exists.  See FindZLIB for an example.  IMPORTED_CONFIGURATIONS
  needs to list the available configurations.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to