I have a concern with generating package configs: 1 It seems to contain absolute path, so not really portable with git. 2 It does not respect the naming of imported targets with `::`. As you can see here: https://cmake.org/cmake/help/git-master/manual/cmake-developer.7.html#a-sample-find-module The fact that it produces an appropriate diagnostic messages if that target does not exist is really helpful.
Thanks, 2016-06-29 15:45 GMT+02:00 Brad King <brad.k...@kitware.com>: > On 06/29/2016 09:40 AM, Chuck Atkins wrote: >> Given these issues, how about we "bring back" the FindJsonCpp module, >> and alter it to explicitly look for the package config first. >> It's still in the Modules tree and is actually used by CMake to build >> itself, it'd just not installed. > > It is in Source/Modules/FindJsonCpp.cmake right now. I'd be fine with > moving it to Modules and distributing it given the upstream situation. > > -Brad > > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/cmake-developers -- Arnaud FARBOS -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers