On Fri, Jul 1, 2016 at 4:12 PM, Ben Boeckel <ben.boec...@kitware.com> wrote: > On Fri, Jul 01, 2016 at 16:44:32 +0300, Dāvis Mosāns wrote: >> 2. change GetEnv to return std::unique_ptr<std:string> which will be >> automatically deleted once out of scope and we still can check if there >> wasn't such env if it's empty. > > Hrm. I'd rather use std::optional than relying on implicit nullptr > semantics.
+1. This class here should be renamed to cmOptional and moved to its own file, so it may be reused: http://public.kitware.com/gitweb?p=stage/cmake.git;a=blob;f=Source/cmArchiveWrite.h;h=f847d09b74922e800293e70c3171accb500c083c;hb=refs/heads/master#l22 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
