2016-07-03 13:04 GMT+03:00 Mike Gelfand <mike...@mikedld.com>: > For std::c(in|out|err) vs. std::wc(in|out|err), here's an implementation > of std::streambuf which we currently use in our projects: > http://stackoverflow.com/a/21728856/583456. You could either try using > it as is or use it as a base for your own implementation; in any case, > it's better than forcing people to use one or another stream based on > current OS. > > Not sure what currently accepted CMake coding style dictates, but > several variables could be made const (e.g. `envVarSet` in > `cmExtraEclipseCDT4Generator::AddEnvVar`). > > Apart from notes above and a few indentation issues which may be fixed > during merge, below are some more observations. > > Huge thanks for review! Will fix mentioned issues in next version of patch. Also I'll implement this solution with std::streambuf as it's much better way and it's actually not that much work I thought it would be.
--
Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
