On 08/16/2016 07:11 AM, Titov Denis wrote:
> This patch introduces several options for the file(DOWNLOAD ...) command, 
> which
> would be useful in case of dealing with big files or unstable network 
> connections.

Nice, thanks.  Good start.  Here are a few minor comments.

> The added options are:

Please also update `Help/command/file.rst` to document these.

> +void crossplatform_sleep(int delay_s)

Please use cmSystemTools::Delay instead.

Thanks,
-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to