> IIUC this refers to: > * http://fastbuild.org > * https://github.com/fastbuild/fastbuild
Yes, exactly. >From a quick glance the main problem I see is that it doesn't follow the Makefile/Ninja generator model of organizing the generator code into a per-target generator. OK, so I need to make use of these. >We can do high-level reviews here first. Alright then. >Please make every commit properly formatted (with clang-format) rather than formatting after-the-fact. I actually remembered about the clang-format thread just before writing the first email, so I thought I should just quickly ut everything to format. >If you've made substantial non-formatting changes from the original >version please record yourself as the author and add a trailer to >the commit message I squashed everything into a big commit to make things easier for me, and completely forgot about proper attribution of the work, so I'll squash all of Josh's commits into one, and all of mine into another and make sure those are correctly formatted. To sum up, what I have to do now is: * squash commits and format those for proper attribuation * refactor to have a cmFastbuildTargetGenerator that inherits cmCommonTargetGenerator * get the tests to pass I guess before it gets fully integrated into CMake 100% test pass is mandatory, but is linux/mac support mandatory also ? Fastbuild does support those platforms, but the generator so far does not work as well (or at all) on those platforms. Best, Charles Le jeu. 22 sept. 2016 à 19:26, Brad King <brad.k...@kitware.com> a écrit : > On 09/22/2016 10:41 AM, Charles Huet wrote: > > a Fastbuild generator in the works, whose development started on CMake > 3.2, > > and was pretty much abandonned for the past 5 months. > > > > I took the time to rebase it on master > > Thanks for reviving it. > > IIUC this refers to: > > * http://fastbuild.org > * https://github.com/fastbuild/fastbuild > > > big design issues can be caught right now > > From a quick glance the main problem I see is that it doesn't follow > the Makefile/Ninja generator model of organizing the generator code > into a per-target generator. See cmCommonTargetGenerator and its > subclasses. We've found that having a per-target generator is much > easier than passing the target pointers around in "local" generators. > > > Should I create a MergeRequest on gitlab? > > That will be fine when you have something ready, preferably after > addressing major architectural issues. We can do high-level reviews > here first. > > > https://github.com/packadal/CMake/tree/fastbuild-master > > Please make every commit properly formatted (with clang-format) > rather than formatting after-the-fact. > > If you've made substantial non-formatting changes from the original > version please record yourself as the author and add a trailer to > the commit message such as > > Co-Author: Josh Green <inbi...@gmail.com> > > or > > Inspired-by: Josh Green <inbi...@gmail.com> > > depending on how much original work remains. > > Thanks, > -Brad > >
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
