Thanks for the information.

 

I am very happy that I do not need to justify the necessity of this feature.

 

On the other hand, I think this feature should also be applied to aux_source_directory() in order to support legacy projects.

 

There are two ways to implement it.

1) Add the same sort logic of the patch(#14491) to cmAuxSourceDirectoryCommand.cxx

2) Apply my patch and remove the sort logic of patch #14491

 

 

Which one do you prefer? I will submit another patch that you prefer.

 

--------- Original Message ---------

Sender : Brad King <brad.k...@kitware.com>

Date : 2016-09-27 20:55 (GMT+9)

Title : Re: [cmake-developers] [PATCH] Sort list of files for aux_source_directory() and file(glob,*)

 

On 09/27/2016 12:20 AM, Junghyun Kim wrote:
> If aux_source_directory(. SRCS) or file(glob SRCS "*.c") is used
> files in SRCS are not sorted.

The file(GLOB) command sorts as of CMake 3.6:

  file: Sort GLOB results to make it deterministic (#14491)
  https://gitlab.kitware.com/cmake/cmake/commit/edcccde7

A similar change could be made to aux_source_directory, though there is
little reason to use that ancient command these days.  Also, the CMake
documentation recommends against using file(GLOB) to collect sources.

-Brad


-------------------------------------------------

Junghyun Kim

Senior Engineer, Ph.D.

Developer Experience Lab.

Software Center

Samsung Electronics Co.,Ltd.

-------------------------------------------------

 


-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to