On Thu, Mar 23, 2017 at 10:50 AM, Brad King <brad.k...@kitware.com> wrote: > On 03/23/2017 11:35 AM, Robert Dailey wrote: >> Thanks Brad. For future reference, are these changes documented >> anywhere? I searched for "enable_language" in the 3.6 release notes, >> and there is no 3.6 entry for policy changes. > > The release notes are for new features, deprecations, and major > user-facing changes. We do not cloud them with every bug fix. > > This enable_language change was a bug fix that prevented a crash > in some cases. I was not aware that there were valid projects > that trigger the error. > > -Brad >
Crystax NDK (on master branch) has a toolchain.cmake which invokes enable_language() but it fails. I guess they didn't test with 3.6 or greater. Basically any of the android.toolchain.cmake scripts floating around have this problem, since they're all modifications of the same base change by takanome: https://github.com/taka-no-me/android-cmake I've introduced a PR on the Crystax project to fix the problem, although I do not know if I'm actually addressing the root cause. My assumption is that the C language is already enabled, but they invoke enable_language(C) anyway for some reason. https://github.com/crystax/android-platform-ndk/pull/16 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
