On 04/20/2017 05:16 PM, Matthew Hanna (BLOOMBERG/ 731 LEX) wrote:
> avoid adding the external to external edges
> https://gitlab.kitware.com/mhanna21/cmake/commit/2c7d2e33b6218e58f88957fb793ce0a781ec76aa
That sounds good. From the patch:
> + if (this->EntryList[depender_index].Target ||
> + this->EntryList[(int)*edge].Target) {
> + edges.push_back(*edge);
> + }
I think only the second condition is needed. To check, try adding:
assert(!this->EntryList[depender_index].Target);
there. I don't think internal targets can get an InferredDependSets
entry, according to logic in `cmComputeLinkDepends::AddLinkEntry`.
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
