On 04/26/2017 04:11 PM, Christoph Grüninger wrote: > thanks for helping me out with the patch. Your wording of the message is > better than my proposal. > Please find attached an improved patch.
Thanks. This is a good start. Please see CONTRIBUTING.rst and open a merge request on gitlab.kitware.com so we can perform further review there. The patch will need more work: * Reject use of OPTIONAL and REQUIRED together. * What about OPTIONAL and QUIET together? * Document _FIND_OPTIONAL for find modules. * Add tests. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
