On 08/24/2017 03:19 AM, Manu wrote: > I have fixed it but I am struggling with the new policy. The > behaviour change goes into cmSystemTools::GetRealPath implementation > and SystemTools has no context, so I am not sure how to check the policy.
The policy would have to be checked higher in the stack and used to choose alternative implementations. > Mimicking policy CMP0067 usage, I could create an old and a new version > of GetRealPath and check for the policy prior calling it all along the code. > On the other hand, I could pass the policy status as a parameter to every > GetRealPath call. Which is the proper way? Likely a second API would be needed. The KWSys GetRealPath could be taught to handle symlinks on Windows. If it turns out a policy is needed then a cmSystemTools:: alternative in CMake only could be added. > To perform a pull request, should I previously open an issue about > this or it is enough with the discusion here in the mailing list. For reference, this issue has been opened: https://gitlab.kitware.com/cmake/cmake/issues/17206 I think we can try this without a policy first. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
