Hi Brad,
Is the below issue solved in latest release 3.11.0 ?
Could you please confirm?
Grüße
Lenin
-----Original Message-----
From: Jayakumar, Lenindarbi
Sent: Freitag, 19. Januar 2018 15:26
To: 'Brad King' <brad.k...@kitware.com>; cmake-developers@cmake.org
Subject: RE: [cmake-developers] CMAKE :: mingw make files with response file
for includes
Thanks for the reply.
It is not compiler and linker.
I have to use response file for both includes and objects.
Tasking compiler expects -f as Response file link flag for both. But cmake
produces command line for objects using -f and includes using @.
I prefer to get it fixed in generator. Unfortunately I don't have enough time
and experience.
Perhaps an cmake expert could confirm and fix it.
Possible cause:
The @ symbol is hardcoded in "cmMakefileTargetGenerator::AddIncludeFlags"
function in file ../Source/cmMakefileTargetGenerator.cxx
if (useResponseFile) {
std::string name = "includes_";
name += lang;
name += ".rsp";
std::string arg = "@" +
this->CreateResponseFile(name.c_str(), includeFlags,
this->FlagFileDepends[lang]);
this->LocalGenerator->AppendFlags(flags, arg);
}
However, the implementation should be like in
"cmMakefileTargetGenerator::CreateObjectLists" function.
// Lookup the response file reference flag.
std::string responseFlagVar = "CMAKE_";
responseFlagVar +=
this->GeneratorTarget->GetLinkerLanguage(this->ConfigName);
responseFlagVar += "_RESPONSE_FILE_LINK_FLAG";
const char* responseFlag = this->Makefile->GetDefinition(responseFlagVar);
if (!responseFlag) {
responseFlag = "@";
}
Thanks,
Lenin
-----Original Message-----
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Freitag, 19. Januar 2018 15:01
To: Jayakumar, Lenindarbi
<lenindarbi.jayaku...@magna.com<mailto:lenindarbi.jayaku...@magna.com>>;
cmake-developers@cmake.org<mailto:cmake-developers@cmake.org>
Subject: Re: [cmake-developers] CMAKE :: mingw make files with response file
for includes
On 01/17/2018 03:52 AM, Jayakumar, Lenindarbi wrote:
> Response file link flag "CMAKE_C_RESPONSE_FILE_LINK_FLAG" is not
> customizable for include paths.
> The @ symbol is hardcoded in "cmMakefileTargetGenerator::AddIncludeFlags"
In case the compiler and link driver want different response file flags, one
could add a separate "CMAKE_<LANG>_RESPONSE_FILE_COMPILE_FLAG" variable to use
for include flags. See
https://gitlab.kitware.com/cmake/cmake/blob/master/CONTRIBUTING.rst
for contribution instructions if you'd like to work on it.
Thanks,
-Brad
--- Begin Message ---
Hello,
I have encountered a problem with response file usage for includes.
My project is using tasking compiler.
Issue:
Response file link flag "CMAKE_C_RESPONSE_FILE_LINK_FLAG" is not customizable
for include paths.
Cmake generated the *.rsp file always using @ but this is not accepted by
tasking compiler. Tasking compiler expects -f instead of @.
...
C_INCLUDES = @CMakeFiles/dummyTarget/includes_C.rsp
This issue is only with includes response file. For objects,
CMAKE_C_RESPONSE_FILE_LINK_FLAG works.
Project setup:
set(CMAKE_C_RESPONSE_FILE_LINK_FLAG "-f ")
set(CMAKE_C_USE_RESPONSE_FILE_FOR_OBJECTS 1)
set(CMAKE_C_USE_RESPONSE_FILE_FOR_INCLUDES 1)
Possible cause:
The @ symbol is hardcoded in "cmMakefileTargetGenerator::AddIncludeFlags"
function in file
https://gitlab.kitware.com/cmake/cmake/blob/master/Source/cmMakefileTargetGenerator.cxx.
if (useResponseFile) {
std::string name = "includes_";
name += lang;
name += ".rsp";
std::string arg = "@" +
this->CreateResponseFile(name.c_str(), includeFlags,
this->FlagFileDepends[lang]);
this->LocalGenerator->AppendFlags(flags, arg);
}
However, the implementation should be like in
"cmMakefileTargetGenerator::CreateObjectLists" function.
// Lookup the response file reference flag.
std::string responseFlagVar = "CMAKE_";
responseFlagVar +=
this->GeneratorTarget->GetLinkerLanguage(this->ConfigName);
responseFlagVar += "_RESPONSE_FILE_LINK_FLAG";
const char* responseFlag = this->Makefile->GetDefinition(responseFlagVar);
if (!responseFlag) {
responseFlag = "@";
}
Regards,
Lenindarbi Jayakumar
Software Engineer
Magna Electronics Europe GmbH & Co. OHG
Kurfürst-Eppstein-Ring 9
63877 Sailauf
OFFICE +49 6093 9942 6462
FAX +49 6093 9942 6001
MOBILE
lenindarbi.jayaku...@magna.com
http://www.magna.com<http://www.magnaelectronics.com/>
Magna Electronics Europe GmbH & Co. OHG
Geschäftsführende Gesellschaft: Magna Electronics Europe Verwaltungs GmbH
Geschäftsführer: Rainer Bruns, Cornelius Wolber
Sitz der geschäftsführenden Gesellschaft: Sailauf, Deutschland
Registergericht: Aschaffenburg / HRB 8778
Sitz der Gesellschaft (OHG): 63877 Sailauf, Deutschland
Registergericht: Aschaffenburg / HRA 4616
Diese Nachricht ist ausschließlich für den oben bezeichneten Adressaten
bestimmt und enthält möglicherweise vertrauliche Informationen. Sollten Sie
nicht der oben bezeichnete Adressat sein oder diese Nachricht irrtümlich
erhalten haben, ersuchen wir Sie, diese Nachricht nicht weiterzugeben, zu
kopieren oder im Vertrauen darauf zu handeln, sondern uns unter
lenindarbi.jayaku...@magna.com zu verständigen und diese Nachricht samt
allfälliger Anlagen sofort zu löschen. Vielen Dank.
This message is intended only for use by the named addressee and may contain
privileged and/or confidential information. If you are not the named addressee,
you should not disseminate, copy, or take any action in reliance on it. If you
have received this message in error, please immediately notify
lenindarbi.jayaku...@magna.com and delete this message and any attachment.
Thank you.
--- End Message ---
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
https://cmake.org/mailman/listinfo/cmake-developers
