Your patch doesn't work with build systems that have configurations (Visual Studio, XCode, etc..). Adding -DQT_DEBUG or -DQT_NO_DEBUG cannot rely on CMAKE_BUILD_TYPE.
What's wrong with leaving it in UseQt4.cmake? In general, things work better if you use UseQt4.cmake (not only because of QT_DEBUG/QT_NO_DEBUG). Clint On Thursday 29 May 2008 12:25:53 pm Tanguy Krotoff wrote: > This thread contained another issue related to UseQt4.cmake and > FindQt4.cmake: > > I wrote a bug report here http://public.kitware.com/Bug/view.php?id=7123 > > >> If you don't want that you don't have to use UseQt4.cmake and use > >> FindQt4.cmake directly. > >> There you have fine grained control over that. > > > > I want to use UseQt4.cmake since it defines important things: > > - QT_DEBUG/QT_NO_DEBUG > > - add ${QT_QTMAIN_LIBRARY} if under Windows > > - all the -DQT_GUI_LIB, -DQT_CORE_LIB... > > I was not using UseQt4.cmake until I encounter some issues under MinGW > > as QT_DEBUG/QT_NO_DEBUG were not defined. > > Probably QT_DEBUG/QT_NO_DEBUG should be moved to FindQt4.cmake as it > > is important. _______________________________________________ CMake mailing list CMake@cmake.org http://www.cmake.org/mailman/listinfo/cmake