On Fri, Jan 9, 2009 at 7:32 AM, Philip Lowman <[email protected]> wrote:
> On Thu, Jan 8, 2009 at 5:22 PM, Albert Astals Cid <[email protected]> wrote: > >> if (LibOpenJPEG_OPENJPEG_LIBRARY) >> set (LibOpenJPEG_LIBRARIES ${openjpeg_LIBRARY}) >> endif (LibOpenJPEG_OPENJPEG_LIBRARY) > > > If you spot any find modules with this syntax this is wrong. The reason why > is if LibOpenJPEG_OPENJPEG_LIBRARY is NOTFOUND then LibOpenJPEG_LIBRARIES > will not be set to NOTFOUND and if the user is linking a target against the > LIBRARIES variable they will get no error because the variable will expand > to nothing. > > Please fix this in your new modules and if you see it anywhere report it as > a bug. > Sorry, forgot to add this. By fix I mean drop the conditional: set(LibOpenJPEG_LIBRARIES ${openjpeg_LIBRARY}) -- Philip Lowman
_______________________________________________ CMake mailing list [email protected] http://www.cmake.org/mailman/listinfo/cmake
