Patch applied and pushed to 'next' today: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=30e19b79ddb00932097ec6f5b54478a0b9b33b38
Thanks again, David On Thu, Jan 13, 2011 at 11:33 PM, Pau Garcia i Quiles <pgqui...@elpauer.org> wrote: > On Thu, Jan 13, 2011 at 3:15 PM, David Cole <david.c...@kitware.com> wrote: >> I am happy to announce that CMake 2.8.4 has entered the release >> candidate stage! You can find the source and binaries here: >> http://www.cmake.org/files/v2.8/?C=M;O=D >> >> Following is the list of changes in this release. Please try this version >> of CMake on your projects and report any issues to the list or the >> bug tracker. >> >> Happy building! >> >> -Dave > > A couple of issues I'd noticed: > > - On Windows, FindZLIB.cmake is unable to find zlib if you built zlib > using CMake. Apparently the zlib's CMake buildsystem uses library > names different from the ones produced by other build methods. > > - FindPNG.cmake does not support libpng 1.5 > > The attached path fixes both issues > > One more thing I've noticed is ExternalProject_Add does not honor the > CMAKE_BUILD_TYPE. For instance, if I have this: > > --8<---------------------------------- > project( winst ) > > cmake_minimum_required(VERSION 2.8) > > include (ExternalProject) > set(CMAKE_PREFIX_PATH ${PROJECT_SOURCE_DIR} ) > > #find_package( PNG REQUIRED ) > > ExternalProject_Add( zlib > DOWNLOAD_DIR ${PROJECT_SOURCE_DIR}/downloads > URL http://prdownloads.sourceforge.net/libpng/zlib125.zip > PATCH_COMMAND ${CMAKE_COMMAND} -E remove zconf.h > CMAKE_ARGS -DCMAKE_INSTALL_PREFIX:PATH=${PROJECT_SOURCE_DIR} > -DCMAKE_PREFIX_PATH:PATH=${PROJECT_SOURCE_DIR} > ) > --8<---------------------------------- > > And I call CMake like "cmake -DCMAKE_BUILD_TYPE=Release", it will > build zlib in Debug. It's easily fixable by adding > "-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}" to the CMAKE_ARGS but I'd say > it violates the principle of least surprise. > > -- > Pau Garcia i Quiles > http://www.elpauer.org > (Due to my workload, I may need 10 days to answer) > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake