On Wed, Apr 11, 2012 at 4:23 AM, Damien Chavarria <roy...@gmail.com> wrote: > > Thank you David & Alex, > > I also have the ASM_NASM language enabled in my CMakeLists.txt files, and > this works for Makefile generators so I'm not sure I understand why there is > more work involved in that area of the code ? It seems to handle nasm fine > to me. > > My problem was only with XCode, and regardless of the Makefile generators, I > think the CMake XCode generator should know about the nasm file type and set > the correct field in the XCode project. David's suggestions looks good to me > and I can submit a patch later today if you guys agree this is the correct > course of action ? >
Yes, please do. (I assume everything works well for you from within Xcode once you set the nasm file types correctly? Everything builds fine?) > If I missed something about the Makefile generators issue please feel free > to explain it to me again and I can also patch there if something is indeed > required. > > Cheers, > Damien. > > > > On Tue, Apr 10, 2012 at 8:43 PM, Alexander Neundorf > <a.neundorf-w...@gmx.net> wrote: >> >> On Tuesday 10 April 2012, David Cole wrote: >> > If you would like to construct a git commit (based on the present >> > 'master' branch), and then attach the patch produced by: >> > >> > git format-patch -1 >> > >> > to the issue at http://public.kitware.com/Bug/view.php?id=9126, then >> > we will consider it for inclusion in a future CMake release. >> > >> > Seems like the easiest thing to do, at least for your case, would >> > simply be add the "nasm" file extension to the code in the recently >> > factored-out function GetSourcecodeValueFromFileExtension in >> > Source/cmGlobalXCodeGenerator.cxx. Adding more known file types to >> > that function will help us keep CMakeLists from being cluttered with >> > too many required source file properties. >> >> Handling of nasm files should be coupled to having the ASM_NASM language >> enabled, that's what has to be done for the makefile-based generators. >> I think the CMakeLists.txt for xcode should do the same. >> Modules/CMakeASM_NASMInformation.cmake lists .nasm and .asm as known file >> extensions. >> >> Alex > > -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake