Hi Chris, To make the process easier, could you create a small project on Gtihub. We would then be able to comment on a line-by-line basis.
Hth Jc On Sat, Feb 23, 2013 at 11:37 PM, Chris Stankevitz < chrisstankev...@gmail.com> wrote: > Hello, > > Would you please critique my CMakeLists.txt and helloConfig.cmake.in > files? I am particularly interested in comments that will help me fix > these problems: > > - In helloConfig.cmake.in, I assume static libraries will be built > (".a"). I imaging a better approach would make no assumptions about > this. > > - In helloConfig.cmake.in, I assume ${PREFIX} will expand to the > installed prefix, but it does not. > > - I type the same expression many times: > "hello-${hello_VERSION_MAJOR}.${hello_VERSION_MINOR}". I imagine the > better approach would derive this expression from some built-in cmake > variables or from a variable I create. > > - INSTALL is looking for helloConfig.cmake in the source directory but > it is in the build directory. > > - Any other comments you have > > Thank you! > > Chris > > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.cmake.org/mailman/listinfo/cmake > -- +1 919 869 8849
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake