On Fri, 14 Sep 2018 at 20:57, Burlen Loring <burlen.lor...@gmail.com> wrote: > why did they MPI_C_LIBRARIES and MPI_C_INCLUDE_DIRS/PATH get changed from > cache variables to not chached variables?
Possibly, that change was due to clean up to correct the module according to the actual CMake conventions https://cmake.org/cmake/help/latest/manual/cmake-developer.7.html#standard-variable-names """ Xxx_INCLUDE_DIRS The final set of include directories listed in one variable for use by client code. This should not be a cache entry. Xxx_LIBRARIES The libraries to link against to use Xxx. These should include full paths. This should not be a cache entry. """ Also, find_package_handle_standard_args description also gives similar hint on the naming: https://cmake.org/cmake/help/latest/module/FindPackageHandleStandardArgs.html """ Therefore these should typically be cache entries such as FOO_LIBRARY and not output variables like FOO_LIBRARIES. """ Best regards, -- Mateusz Loskot, http://mateusz.loskot.net -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: https://cmake.org/mailman/listinfo/cmake
