Sent from my iPhone
On Nov 13, 2009, at 4:16 PM, Cristian Ciupitu <cristian.ciup...@yahoo.com > wrote: >> From: Jeff Schroeder <jeffschr...@gmail.com> > >> To: cobbler development list <cobbler-devel@lists.fedorahosted.org> >> Sent: Sat, November 14, 2009 12:13:09 AM >> Subject: Re: [PATCH] Logging and cli error patches for master >> >> On Fri, Nov 13, 2009 at 2:09 PM, Cristian Ciupitu >> wrote: >>>> From: "Vreman, Peter" >>> >>>> To: cobbler development list >>>> Sent: Fri, November 13, 2009 4:20:14 PM >>>> Subject: RE: [PATCH] Logging and cli error patches for master >>>> >>>> ..... >>>> I copied only the code from cobbler/utils.py. This optimization >>>> shall then be >>>> applied to both koan and cobbler. Or maybe even better make koan >>>> and cobbler >>>> share the same module. >>> >>> I've noticed too that there is some code shared (copied) between >>> koan and >>> cobbler. Maybe it's time to extract a common package for this >>> code, something >>> like cobbler-common. I would like to hear other opinions regarding >>> this. >> >> Why add more dependencies for koan? koan is a very small standalone >> utility and cobbler is a server side component. Lets keep them >> seperate if at all possible. > > Could you please explain why are you concerned about adding a > dependency for > koan? After all, package managers can deal with dependencies. > > I was also thinking of using symbolic links and then package these > modules in both > cobbler and koan, but then I realized that one of the packages would > contain a broken > link unless we do some tricks in the spec or setup.py. Sorry I'm not sure what got into me earlier but for heavens sake don't use symlinks to do this. Splitting stuff out makes sense and shouldn't be super hard. I know that keeping koan small and self contained was very important for Michael when he wrote it. He got it running fine on rhel2.1 to help migrate those installs over to virtual machines. Not that I personally mind, but it would be sad to see that work thrown out for a seemingly innocent patch. _______________________________________________ cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel
