Anderson Silva wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > >> The report code is in commands.py which is pretty much the only file > you > >>> really need to change. >>> >>> If you would want to create a file like action_report.py and move all >>> the code into there I think that's reasonable too. commands.py >>> could call out to that. >>> >>> We probably don't want a file for each different output format, I >>> imagine they are all rather short and can live in that one file. >>> >>> No worries though, if you submit something and we decided to rearrange >>> it later, that's not a problem. >>> > > > Alright, so as I've done more reading on the code, I am not sure how > excited I'd be about hardcoding templates into commands.py... Plus, part > of the idea of cobblersysreport was to generate a table/grid like output > for quick documentation on a wiki. >
I don't believe anything was said about "hardcoding" anything. > For the amount of information given out by cobbler report --what=all > (for example), I don't think a table like output would make much sense. > Which is why we only want to generate reports for certain things/fields, yes... > And the idea to filter the fields is a good one, but that can be > accomplished by using egrep, like: > > [EMAIL PROTECTED] ~]# cobbler report --what=all | egrep -e "(system|mac)" > system : build01_re_redhat_com > mac address : 00:16:3e:01:4a:b9 > system : buildmaster01_re_redhat_com > mac address : 00:16:3e:76:4f:69 > system : buildnode01_re_redhat_com > mac address : 00:0F:1F:03:FE:63 > system : buildnode02_re_redhat_com > mac address : 00:16:3e:4d:98:52 > system : cobbler_re_redhat_com > mac address : 00:16:3e:3b:26:14 > Grep doesn't make sense when wanting to report table formatted output like what you were opposing. > > So, unless anyone disagrees with me and have a good argument to try to > keep moving any of those features into cobbler itself, I will go ahead > and withdraw from this 'feature' for cobbler. > > If you don't want to add it after all, don't add it. I'm not sure I understand the change of heart, but I am not going to argue with someone about adding a feature they don't want to add. > Let me know. > > AS > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.7 (GNU/Linux) > Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org > > iD8DBQFImy7TECmX3C4JWKgRAvblAJ0eT5b86jYN7jYCdjbbGozKRO1zmwCeMD5F > PUhMDtkBI9C/VBpmhFi9jAY= > =iM/X > -----END PGP SIGNATURE----- > _______________________________________________ > cobbler mailing list > [email protected] > https://fedorahosted.org/mailman/listinfo/cobbler > _______________________________________________ cobbler mailing list [email protected] https://fedorahosted.org/mailman/listinfo/cobbler
