Re: [Cocci] About nesting if else code

[Julia Lawall]

> retval = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> if (retval) {
>    retval = dma_set_coherent_mask(&pdev->dev,
>                       DMA_BIT_MASK(32));
>    if (retval) {
>        dev_err(&pdev->dev,
>            "No usable DMA config, aborting\n");
>        goto err_alloc_pci_res_mem;
>    }
> }

This is not usable code because it has a goto with no destination.  I made
the following function:

int main () {
retval = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
if (retval) {
   retval = dma_set_coherent_mask(&pdev->dev,
                      DMA_BIT_MASK(32));
   if (retval) {
       dev_err(&pdev->dev,
           "No usable DMA config, aborting\n");
       goto err_alloc_pci_res_mem;
   }
}
  err_alloc_pci_res_mem:
return;
}

For me it crashes with the message:

Fatal error: exception Invalid_argument("equal: abstract value")

Do you get that message?  I will fix this problem, but if you are getting
some other behavior, maybe you could send a more complete example with the
destination label of the goto?

thanks,
julia
_______________________________________________
Cocci mailing list
Cocci@diku.dk
http://lists.diku.dk/mailman/listinfo/cocci
(Web access from inside DIKUs LAN only)